Precompile assets before testing #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
reviewed
Oct 18, 2024
Rakefile
Outdated
| @@ -39,6 +39,9 @@ task ci: ['engine_cart:generate'] do | |||
| SolrWrapper.wrap(port: '8983') do |solr| | |||
| solr.with_collection(name: 'blacklight-core', dir: 'lib/generators/spotlight/templates/solr/conf') do | |||
| Rake::Task['spotlight:fixtures'].invoke | |||
| within_test_app do | |||
| system 'bin/rake assets:precompile' | |||
There was a problem hiding this comment.
typically this is done by spec:prepare. I believe this is done automatically by rake spec
There was a problem hiding this comment.
assets:precompile is for deploying to prod
I think this is better suited here rather than in the generator.
taylor-steve
force-pushed
the
precompile-assets-in-ci
branch
from
7fbebd2
to
d09abbe
Compare
jcoyne
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is better suited here rather than in the generator.