Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding guidelines for alt text to specific sir trevor blocks #3188

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

hudajkhan
Copy link
Contributor

Closes #3187 and sul-dlss/exhibits#2582.

What this pull request does:

  • Add the guidelines intro, link label, and url to the locales file for Sir Trevor Blocks.
  • Display these guidelines in widgets where alt text can be added: various versions of item views (fueled by a base solr document block) such as item row, item carousel, item grid, and item slideshow, and the uploaded items block.

@taylor-steve
Copy link
Contributor

@hudajkhan I tried this, and it works well. What do you think about adding tests, maybe piggybacking on/adjacent to the alt text feature tests from https://github.com/projectblacklight/spotlight/pull/3180/files? Literally only checking for existence/non-existence of the link. Worth it?

@hudajkhan
Copy link
Contributor Author

Thank you for helping me out @taylor-steve . I have added some tests.

@taylor-steve taylor-steve merged commit 7be50d7 into main Oct 17, 2024
6 checks passed
@taylor-steve taylor-steve deleted the altlink branch October 17, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature:
2 participants