refactor: Added parameters to the db requests to fit usage #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added some ordering paramters to properly fit usage. We are now showing the UNPAID and latest Invoices instead of showing the PAID and oldest - Changed default expiring date from TWO WEEKS to ONE WEEK
itschip
reviewed
Nov 17, 2022
| @@ -7,14 +7,14 @@ import { Transaction } from 'sequelize/types'; | |||
| @singleton() | |||
| export class InvoiceDB { | |||
| async getAllInvoices(): Promise<InvoiceModel[]> { | |||
| return await InvoiceModel.findAll(); | |||
| return await InvoiceModel.findAll({ order: [['status', 'DESC'], ['createdAt', 'DESC']]}); | |||
There was a problem hiding this comment.
What value does status have here again?
There was a problem hiding this comment.
It's to filter on the status which are "PAID", "PENDING", etc.. Like that we can view the pending invoices and the earliest ones instead of the oldest and paid ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Pull Request Checklist:
resourcein-game after the relevant change?