Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit exporter fix #64

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

maia-iyer
Copy link
Collaborator

Changes value of exporter for deleted appwrappers from -1 to 0.
The default for unknown values is changed from 0 to -1.

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer self-assigned this Oct 30, 2023
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -1 case for default should be removed on the frontend side, that will account for the graph being shifted in the y. Other than that lgtm! I will adjust that case. Thanks.

@mamy-CS mamy-CS merged commit c1d15b4 into project-codeflare:main Oct 30, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants