Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix appwrapper table #57

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Fix appwrapper table #57

merged 7 commits into from
Sep 26, 2023

Conversation

maia-iyer
Copy link
Collaborator

This PR does the following:

  • modifies the appwrapper call to occur in the frontend by /api/k8s endpoint exposed by the backend
  • removes the /api/appwrappers endpoint from the backend
  • also gets appwrappers by Openshift project that is exposed to a given user

@maia-iyer
Frontend calls K8s endpoint for appwrappers
99adcfb 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
Get appwrappers only from proper namespaces
619a330 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
added comment
f68db61 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
add manual workflow trigger
431f155 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
remove appwrapper script from Dockerfile
56cbd94 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
Change appwrapper apiversion to workload.codeflare.dev
2821eb6 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer added the enhancement New feature or request label Sep 19, 2023
@maia-iyer maia-iyer self-assigned this Sep 19, 2023
@maia-iyer
Adjusted isAdmin case for listing appwrapper call
8620f6c 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer marked this pull request as ready for review September 22, 2023 14:43
@mamy-CS mamy-CS merged commit d1e965d into project-codeflare:main Sep 26, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maia-iyer maia-iyer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maia-iyer @mamy-CS