Skip to content

Commit

Permalink
fixing reused test ids
Browse files Browse the repository at this point in the history
  • Loading branch information
patrick-rodgers committed Aug 10, 2023
1 parent 7ea2633 commit d9a50e9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/core/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ describe("isFunc", function () {
})).to.be.true;
}));

it("False", pnpTest("ff0020e6-0e1b-4b12-a4a1-8a4b2fc8fcdb", function () {
it("False", pnpTest("2a147d36-64ad-4888-a425-e4d18ead4448", function () {
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
expect(isFunc({ val: 0 })).to.be.false;
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
Expand Down
2 changes: 1 addition & 1 deletion test/pnp-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function PnPTestIdHeader(id: () => string): TimelinePipe {
export function pnpTest(id: string, testFunc: (this: IPnPTestFuncThis) => any): IPnPTestFunc {

if (idDupeTracker.indexOf(id.toLowerCase()) > -1) {
throw Error(`Test ${id} is already in use.`);
throw Error(`Test id ${id} is already in use.`);
}

idDupeTracker.push(id.toLowerCase());
Expand Down
2 changes: 1 addition & 1 deletion test/sp/batch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ describe("Batching", function () {
expect(p2).to.eventually.be.fulfilled;
}));

it("Should rebase objects to allow queries on returned objects", pnpTest("d9535bc2-c59a-49ba-8666-b3d80510aca5", async function () {
it("Should rebase objects to allow queries on returned objects", pnpTest("5e17585b-ce83-4fd0-8392-1132069b5503", async function () {

const props = await this.props({
listName: "BatchTestRebase",
Expand Down

0 comments on commit d9a50e9

Please sign in to comment.