Implemented vanilla /xp command. #6429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShockedPlot7560
added
Category: Gameplay
IvanCraft623
reviewed
Sep 1, 2024
| } | ||
| $xpManager = $player->getXpManager(); | ||
| if(str_ends_with($args[0], "L")){ | ||
| $xpLevelAttr = $player->getAttributeMap()->get(Attribute::EXPERIENCE_LEVEL) ?? throw new AssumptionFailedError(); |
There was a problem hiding this comment.
Suggested change
| $xpLevelAttr = $player->getAttributeMap()->get(Attribute::EXPERIENCE_LEVEL) ?? throw new AssumptionFailedError(); | |
| /** @var Attribute $xpLevelAttr */ | |
| $xpLevelAttr = $player->getAttributeMap()->get(Attribute::EXPERIENCE_LEVEL); |
There was a problem hiding this comment.
IIRC, @var in PM code shouldn’t be used for such assertions. Also, I’ve found similar assertion via AssumptionFailedError in the code for another attribute that should always exist by default too (https://github.com/pmmp/PocketMine-MP/blob/stable/src/network/mcpe/handler/InGamePacketHandler.php#L510)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR implements /xp command from vanilla. Also, I think it would be convenient to have a built-in command that can give you experience levels to test enchanting tables / anvils instead of farming experience from bottles.
Changes
API changes
Added
ExperienceCommandAdded 2 new permissions:
Follow-up
Before accepting this PR you need to add new translations into
pmmp/LanguagerepoSee pmmp/Language#185
Requires translations:
|
pocketmine.command.xp.description|Adds or removes player experience||
pocketmine.permission.command.xp.other|Allows the user to add or remove experience of other players||
pocketmine.permission.command.xp.self|Allows the user to add or remove their experience||
pocketmine.command.xp.usage|/xp <experience[L]> [player]||
commands.xp.failure.widthdrawXp|Cannot give player negative experience points||
commands.xp.success|Gave {%0} experience to {%1}||
commands.xp.success.levels|Gave {%0} experience levels to {%1}||
commands.xp.success.negative.levels|Taken {%0} levels from {%1}|Tests
I tested this PR by doing the following: