Blobs #2
Closed
Blobs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code recognizes blobs in two message content types: about and post. For about messages the code checks the "image" field. This field can be a string containing a blob ref or a mention object. For post messages the code checks the mentions field. This field is a list of mention objects.
One thing that comes to mind is storing another reason for keeping a blob e.g. explicit pin requests made by the UI. Another thing could be caching the size of a blob.
boreq
force-pushed
the
blobs
branch
2 times, most recently
from
94c9cdc
to
3a6cae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1.