Add support for Pydantic v2 #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
|
||
| # In the case of StuffingContextBuilder, we simply want the text representation to | ||
| # be a json. Other ContextContent subclasses may render into text differently | ||
| def to_text(self, **kwargs): | ||
| return self.json(**kwargs) | ||
| return json.dumps(self.model_dump(), **kwargs) |
There was a problem hiding this comment.
Why not use self.dump_json()?
There was a problem hiding this comment.
Because we pass args to json_dumps (such as indent). This was supported in v1 but not v2 (.model_dump_json does not get indent in pydantic v2)
| @@ -127,7 +127,7 @@ def expected_chunks(documents): | |||
| '\ntext in level 3\n#### Level 4\ntext in level 4\n##### Level 5' | |||
| '\ntext in level 5\n###### Level 6\ntext in level 6', | |||
| source='doc_1', | |||
| metadata={'test': '1'}, | |||
There was a problem hiding this comment.
Why was this cast to str before? (Seems like we had a bug?)
There was a problem hiding this comment.
Kinda bug of Union parsing in pydantic v1. In pydantic v2 there is smart unions so they fixed this problem.
|
@izellevy please make sure you run tests at least once (locally on your machine) with |
|
@igiloh-pinecone checked and made sure it works with all extras |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently we only support Pydantic v1 which is a problem for some users.
Solution
Migrating to Pydantic v2
Type of Change
Test Plan
Describe specific steps for validating this change.