Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker build #286

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix docker build #286

merged 1 commit into from
Feb 12, 2024

Conversation

izellevy
Copy link
Collaborator

@izellevy izellevy commented Feb 11, 2024 •
edited
Loading

Problem

Docker build cannot get the poetry install args correctly.

Solution

Changed the makefile and the CI for string expressions.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

@izellevy izellevy requested a review from acatav February 11, 2024 12:10
@izellevy izellevy added this pull request to the merge queue Feb 11, 2024
acatav
acatav approved these changes Feb 11, 2024
View reviewed changes
Copy link
Contributor

@acatav acatav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

igiloh-pinecone
igiloh-pinecone approved these changes Feb 11, 2024
View reviewed changes
Copy link
Collaborator

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2024
@izellevy izellevy added this pull request to the merge queue Feb 12, 2024
Merged via the queue into pinecone-io:main with commit 1052edb Feb 12, 2024
7 checks passed
@izellevy izellevy deleted the bug/fix_image_build branch February 12, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatav acatav acatav approved these changes

@igiloh-pinecone igiloh-pinecone igiloh-pinecone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izellevy @acatav @igiloh-pinecone