-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove prometheus/client_golang
replace
#682
Conversation
prometheus/client_golang
replace
We use the lastest version of client_golang and exporter-toolkit in grafana/agent. This make some compability issues with the exporter. We can either try to upgrade and fix issues here or downgrade in grafana/agent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marctc Awesome, thanks for your contribution!
We will have to discuss internally when we can upgrade to the latest version of Thanks anyway! |
What does new versions of client_golang have that makes v1 not work? |
I just bumped |
a9851d6
to
f1c1ce9
Compare
I believe the failing test is flaky. I tried locally and it worked. |
* Remove prometheus/client_golang replace * Apply formater * Downgrade client_golang to previous version * Upgrade exporter-toolkit to v0.10.0
* added multi target feature * added connect timeout opts * added tests * fixed test * fixed dockerfile * Bump github.com/golangci/golangci-lint from 1.47.3 to 1.52.2 in /tools (#639) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.47.3 to 1.52.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.47.3...v1.52.2) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/golangci/golangci-lint from 1.52.2 to 1.53.2 in /tools (#665) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.52.2 to 1.53.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.52.2...v1.53.2) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove `prometheus/client_golang` replace (#682) * Remove prometheus/client_golang replace * Apply formater * Downgrade client_golang to previous version * Upgrade exporter-toolkit to v0.10.0 * added multi target feature * added connect timeout opts * fixed connect * formatted code * fixed linter warnings * Update README.md * Update README.md * updated license * Update exporter/server.go Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com> * fixed according to review * formatted the code * minor changes according to the linters --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marc Tudurí <marctc@protonmail.com> Co-authored-by: Jiří Čtvrtka <62988319+JiriCtvrtka@users.noreply.github.com> Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com> Co-authored-by: Nurlan Moldomurov <bupychuk1989@gmail.com>
Hello, @marctc! Thank you for your contributions! We would like to send you a gift from Percona. Please, contact us at community-team@percona.com. |
This PR removes the usage of the custom fork of
prometheus/client_golang
addingMeasureCollectTime
.The function is moved to the exporter itself that IMO makes more sense to exist here than the
the instrumentation library.
This would allow us to include last exporter changes with license issues fixed in grafana agent.
Fixes #574
Once all checks pass and the code is ready for review, please add
pmm-review-exporters
team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.