Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Venmo shell #281

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Add Venmo shell #281

merged 7 commits into from
Jul 9, 2024

Conversation

richherrera
Copy link
Contributor

Reason for changes

DTMOBILES-775

  • Create the shell for the Venmo integration within the demo app.
    Once we start implementing Venmo features, we will fill in this shell with a testable Venmo experience.

Summary of changes

  • Add VenmoPaymentView
  • Add VenmoPaymentsViewModel
  • Add new settings selection for Venmo Payments

Checklist

  • [] Added a changelog entry

Authors

@richherrera richherrera requested a review from a team as a code owner July 8, 2024 21:19
@richherrera richherrera changed the title Add Venmo _shell_ Add Venmo shell Jul 8, 2024
@richherrera richherrera self-assigned this Jul 8, 2024

struct VenmoPaymentView: View {

@ObservedObject var venmoPaymentsViewModel = VenmoPaymentsViewModel()
Copy link
Collaborator

@KunJeongPark KunJeongPark Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that @StateObject should be used where the VM is instantiated.
Otherwise, it looks great. "Hello Venmo!"

Copy link
Collaborator

@agedd agedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

@richherrera richherrera merged commit 23b28f4 into venmo-feature Jul 9, 2024
5 checks passed
@richherrera richherrera deleted the add-venmo-shell branch July 9, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants