Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PayPalVaultRequest required URL param #279

Merged
merged 10 commits into from
Jul 10, 2024
Merged

Conversation

scannillo
Copy link
Collaborator

@scannillo scannillo commented Jun 27, 2024

Reason for changes

DTMOBILES-680

  • Currently, a merchant has to provide the SDK a URL to launch for the PP Vault w/o Purchase flow. This is not a great dev-ex since the SDK should provide more value and know which URL to launch.
  • The JS SDK hard codes the URLs to launch for this experience, so the mobile SDKs can follow suit.

Summary of changes

  • Deprecate PayPalVaultRequest.init(url:setupTokenID:)
  • Add PayPalVaultRequest.init(setupTokenID:)
  • Add logic to SDK to construct vault w/o purchase URL itself

Checklist

  • Added a changelog entry

Authors

@scannillo

@scannillo scannillo marked this pull request as ready for review June 27, 2024 14:42
@scannillo scannillo requested a review from a team as a code owner June 27, 2024 14:42
CHANGELOG.md Outdated Show resolved Hide resolved

/// Creates an instance of a PayPal vault request
/// - Parameter setupTokenID: An ID for the setup token associated with the vault
public init(setupTokenID: String) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Co-authored-by: Jax DesMarais-Leder <jdesmarais@paypal.com>
@KunJeongPark
Copy link
Collaborator

Great job Sammy!

@scannillo scannillo merged commit 1eb22f1 into main Jul 10, 2024
5 checks passed
@scannillo scannillo deleted the remove-pp-vault-url branch July 10, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants