Add button analytics #261
Add button analytics #261
Conversation
|
Changes look good! Another nit - but I think we do want a CHANGELOG entry here, it helps future us track which version we added these analytics in |
| @@ -36,7 +46,9 @@ public class PaymentButton: UIButton { | |||
| self.size = size | |||
| self.insets = insets | |||
| self.label = label | |||
| self.analyticsService.sendEvent("paypal-button:initialized", buttonType: fundingSource.rawValue) | |||
There was a problem hiding this comment.
General question: do we want to send a specific event for each PaymentButton subclass - so credit, pay later, paypal. Or are we sending the same event name for all buttons?
There was a problem hiding this comment.
Its the same event name for all buttons but we also pass the buttonType which would be one of PayPal Pay Later or Credit
There was a problem hiding this comment.
🤦 it certainly helps if I could read, sorry just totally missed the second half of this event. Take it or leave it, but is it worth considering payment-button as the naming here? Wondering incase we add something like a Venmo button in the future would we reused this class.
There was a problem hiding this comment.
@vradopp what do you think about updating the events in this PR to "payment-button" vs "paypal-button"?
There was a problem hiding this comment.
Sounds good to me! Just updated
do you mind pointing me where to look for existing tags? Not sure how to verify if |
I can help answer this! If you go to |
Reason for changes
Log payment button usage
Summary of changes
button_typewhich is an existing tag to track the type of button usedpayment-button:tappedandpayment-button:initializedChecklist
- [ ] Added a changelog entryAuthors