Fixed PaymentButton sizing issue
#255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jax DesMarais-Leder <jdesmarais@paypal.com>
warmkesselj
reviewed
Feb 26, 2024
| @@ -111,6 +111,7 @@ struct SwiftUIPaymentButtonDemo: View { | |||
| size: selectedSize | |||
| ) | |||
| .id(buttonID) | |||
| .frame(maxWidth: .infinity) | |||
There was a problem hiding this comment.
Are these needed? I removed them and tested in canvas and sim and seem to be okay without these changes.
There was a problem hiding this comment.
They're not needed but I have them there so that people, internally and externally, who aren't familiar with SwiftUI know that you can set the button widths. Pre-PR, this part was broken and you couldn't customize the width in SwiftUI. If it feels redundant and unnecessary, I can remove it
There was a problem hiding this comment.
Maybe better to remove them if they're not necessary.
There was a problem hiding this comment.
Gotcha, I'll update but will leave one of the in
jaxdesmarais
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for changes
This PR is copied from the original #247, which was branched from
next-major-versionand we concluded that this change is non-breaking and should go intomain. So this PR is branched frommainThere was a sizing issue with the Payment Button when used in SwiftUI apps
Summary of changes
Checklist
Authors