New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vault Without Purchase #173

Merged

sshropshire merged 52 commits into main from merchant_server_vault_without_purchase

Aug 17, 2023

Collaborator

sshropshire commented Aug 8, 2023 •

edited

Loading

Summary of changes

Implement server initiated Vault without Purchase
Add CardClient#vault() method
Add VaultRequest and VaultResult types for interacting with the CardClient#vault() method
Add VaultListener interface to receive CardClient#vault() success and failure results
Add vaultListener property to CardClient
iOS equivalent PR: Vault without Purchase paypal-ios#172

vault-without-purchase-downscaled.mp4

Checklist

Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire

sshropshire marked this pull request as ready for review

August 9, 2023 15:51

sshropshire requested a review from a team as a code owner

August 9, 2023 15:51

scannillo reviewed

View reviewed changes

CardPayments/src/main/java/com/paypal/android/cardpayments/VaultResult.kt Show resolved Hide resolved

scannillo reviewed

View reviewed changes

CardPayments/src/main/java/com/paypal/android/cardpayments/DataVaultPaymentMethodTokensAPI.kt Outdated Show resolved Hide resolved

scannillo reviewed

View reviewed changes

CardPayments/src/main/java/com/paypal/android/cardpayments/VaultListener.kt Show resolved Hide resolved

scannillo reviewed

View reviewed changes

CardPayments/src/main/java/com/paypal/android/cardpayments/CardClient.kt Show resolved Hide resolved

scannillo reviewed

View reviewed changes

CardPayments/src/main/res/raw/graphql_query_update_setup_token.graphql Outdated Show resolved Hide resolved

jaxdesmarais reviewed

View reviewed changes

CardPayments/src/main/java/com/paypal/android/cardpayments/CardClient.kt Outdated Show resolved Hide resolved

CardPayments/src/main/java/com/paypal/android/cardpayments/DataVaultPaymentMethodTokensAPI.kt Show resolved Hide resolved

CardPayments/src/main/res/raw/graphql_query_update_setup_token.graphql Outdated Show resolved Hide resolved

CorePayments/src/main/java/com/paypal/android/corepayments/ResourceLoader.kt Show resolved Hide resolved

CorePayments/src/main/java/com/paypal/android/corepayments/api/EligibilityAPI.kt Show resolved Hide resolved

scannillo reviewed

View reviewed changes

CorePayments/src/main/java/com/paypal/android/corepayments/graphql/common/GraphQLClient.kt Show resolved Hide resolved

sshropshire added 21 commits

August 14, 2023 14:30


          Stub CreateSetupTokenUseCase.

9e8ec46


          Add CreatePaymentToken use case.

243e0e1


          Stub out VaultFragment.

851e6e7


          Insert VaultFragment into navigation graph.

496d2ee


          Extract card form from vault fragment.

e1eaa27


          Add vault ui state and vault ui model to vault fragment.

72bd864


          Add additional vault step to VaultFragment.

a35f4e0


          Add additional state to allow vaulting by updating the setup token.

5b7df4f


          Stub out create payment token method.

db1a733


          Implement Vault without purchase in Vault Fragment.

c7741c1


          Print Payment token output on vault without purchase.

4f6a4de


          Extract PaymentTokenView from VaultFragment.

ce2e9ad


          Create SetupToken data class in demo app.

9f27c65


          Add Setup token view to vault fragment.

ffdd06d


          Add vault success view to vault fragment.

7f6e188


          Scroll to bottom of vault fragment as updates occur.

dac6a71


          Clean up lint errors.

9754ea9


          Fix unit tests and add mockk workaround for spying on java.net.URL in…

be68360

…stances.


          Update GraphQLClient to take queryname parameter in send method.

1659a3a


          Append query name parameter to DataVaultPaymentMethodTokensAPI GraphQ…

d3a671a

…L url.


          Remove references to Vaulting from CardFragment.

b10368b

sshropshire and others added 17 commits

August 14, 2023 14:30


          Add unit test for parsing GraphQL result.

e344633


          Fix lint errors.

ad54948


          Remove suspend qualifier from CardClient#vault.

bcc9945


          Update CHANGELOG and annotate library private methods to discourage e…

da34bef

…xternal usage.


          Move graphql_query_update_setup_token.graphql raw resource into CardP…

…ayments module.


          Add docs to CardClient for vault related payment methods.

9c5c3ae


          Move vault method and add unit test for success path.

3cd0e2f


          Add error case test for CardClient.vault method.

34c67a0


          Remove additional methods in CardClient to clean up lint errors.


          Add docs to VaultListener.

adeb34b


          Add docs for VaultRequest.

4706f2c


          Add docs for VaultResult type.

306f2c2


          Update CardPayments/src/main/res/raw/graphql_query_update_setup_token…

40f89d3

….graphql

Co-authored-by: Jax DesMarais-Leder <jdesmarais@paypal.com>


          Fix error message left over from copy/paste.


          Fix GraphQL formatting.

13fb283


          Add context parameter to loadRawResource documentation on ResourceLoa…

012d984

…der.


          Add missing context annotation in Eligibility API.

bd4a6fc

sshropshire force-pushed the merchant_server_vault_without_purchase branch from cf54923 to bd4a6fc Compare

August 14, 2023 19:30

scannillo reviewed

View reviewed changes

Demo/src/main/java/com/paypal/android/ui/vault/VaultFragment.kt

+                                          uiState = uiState,
+                                          onCreateSetupTokenSubmit = { createSetupToken() },
+                                          onAttachCardToSetupTokenSubmit = { attachCardToSetupToken() },
+                                          onCreatePaymentTokenSubmit = { createPaymentToken() },

Collaborator

scannillo Aug 14, 2023

Same Q as on iOS - do we need to display the paymentToken in our Demo? Also, i'm still unclear on what a merchant is supposed to do with a paymentToken on their server after they get it

Collaborator Author

sshropshire Aug 15, 2023

The demo app is designed to highlight interactions between client and server. Displaying the payment token is evidence that the vault completed successfully. A payment token can be used as a payment_source in PPaaS, I believe.

Collaborator Author

sshropshire Aug 15, 2023

The demo app is designed to highlight interactions between client and server. Displaying the payment token is evidence that the vault completed successfully. A payment token can be used as a payment_source in PPaaS, I believe.

sshropshire added 5 commits

August 14, 2023 15:46


          Add suppress annotations for methods that are not yet fully ready for…

e4f2d17

… release.


          Remove Vault class that's no longer needed.

11f4582


          Fix CHANGELOG merge issue.

ffb0290


          Remove additional CHANGELOG issues that were duplicated.

44e302d


          Add back approve order failure notification method.

48bcaf7

scannillo approved these changes

View reviewed changes

Collaborator

scannillo left a comment

🎊 Awesome! Last comment I have is that we make a ticket for updating our docs/ directory with vault instructions

Collaborator Author

sshropshire commented Aug 15, 2023

Last comment I have is that we make a ticket for updating our docs/ directory with vault instructions

We do have DTPPCPSDK-700 that involves docs. We haven't done docs driven here mostly because we were learning each step of the way.

scannillo mentioned this pull request

Vault without Purchase paypal/paypal-ios#172

Merged

1 task

KunJeongPark approved these changes

View reviewed changes

sshropshire merged commit dbe0fe0 into main

6 checks passed

sshropshire deleted the merchant_server_vault_without_purchase branch

August 17, 2023 19:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet