Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff to version 0.5.5 #21235

Closed

Conversation

krishnan-chandra
Copy link
Contributor

@krishnan-chandra krishnan-chandra commented Jul 30, 2024

It's been about a month and a half since last update. I'll try to keep bumping the version on a relatively frequent, but hopefully not annoying interval.

@krishnan-chandra krishnan-chandra added category:internal CI, fixes for not-yet-released features, etc. backend: Python Python backend-related issues labels Jul 30, 2024
@krishnan-chandra
Copy link
Contributor Author

krishnan-chandra commented Jul 30, 2024

Looks like tests are failing because the Pip version was bumped alongside Pex and no longer supports Python 3.7. I can regenerate the lockfile with a lower version of Pip, but we'll probably run into this again.

Related issues: #21103 #20852

@huonw
Copy link
Contributor

huonw commented Jul 31, 2024

This prompted me to dust of a branch and put up #21237, thanks.

That will allow side-stepping the interpreter constraint issues, and also makes supporting many ruff versions simpler (i.e. there's less annoyance from bumping often, because users can pin easily).

Can you take a look and let me know what you think?

@krishnan-chandra
Copy link
Contributor Author

There have been many more updates to ruff since I opened this PR, so I'll just close this and make a new PR at a later time after #21237 is merged.

@krishnan-chandra krishnan-chandra deleted the upgrade-ruff-0.5.5 branch September 6, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Python Python backend-related issues category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants