Don't override the ICs in the pants script on MacOS Silicon. #19603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to need this because pants ran on Python 3.7-3.9 generally, but only on 3.9 on MacOS Silicon. It is no longer necessary to do so, since the repo-wide ICs are 3.9.* anyway now. Setting this was not harmless, as it would override the ICs in other repos when running from sources with PANTS_SOURCE=.
|
Fixes #19602 |
Eric-Arellano
approved these changes
Aug 14, 2023
|
Note that we still is |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to need this because pants ran on Python 3.7-3.9
generally, but only on 3.9 on MacOS Silicon.
It is no longer necessary to do so, since the repo-wide ICs
are 3.9.* anyway now.
Setting this is not harmless, as it would override the ICs in
other repos when running from sources with PANTS_SOURCE=.