Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-2066] fix(utility): Update extractMetadataAsString #36

Merged
merged 5 commits into from
Sep 2, 2024

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Aug 30, 2024

List of Changes

  • Update extractMetadataAsString: key suffix has been added when GenericPair is 1

this update changes AuthConfiguration metadata in body request POST /cache/domains/{domain}, executed when addAuthConfigurationToAPIMAuthorizer is called

Motivation and Context

When otherMetadata in SubscriptionKeyDomain is

"otherMetadata": [
    {
        "name": "metadata name",
        "shortKey": "_short",
        "content": [
            {
                "key": "77777777777",
                "value": "00"
            }
        ]
    }
],

Authorizer could add a suffix key to improve verification

AS-IS: metadata=_short=00;;

TO-BE: metadata=_short=77777777777:00;;

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang added the patch label Aug 30, 2024
@cap-ang cap-ang self-assigned this Aug 30, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['bug', 'enhancement', 'breaking-change', 'ignore-for-release']

Copy link
Contributor

@andrea-deri andrea-deri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

Copy link

sonarcloud bot commented Sep 2, 2024

@cap-ang cap-ang added bug Something isn't working and removed patch labels Sep 2, 2024
@cap-ang cap-ang merged commit 4f8a13b into main Sep 2, 2024
9 of 10 checks passed
@cap-ang cap-ang deleted the PAGOPA-2066 branch September 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants