Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PAGOPA-1300 remove apim sub-key from header #20

Merged
merged 4 commits into from
Oct 27, 2023
Merged

fix: PAGOPA-1300 remove apim sub-key from header #20

merged 4 commits into from
Oct 27, 2023

Conversation

aomegax
Copy link
Contributor

@aomegax aomegax commented Mar 21, 2023

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

github-actions[bot]
github-actions bot requested changes Mar 21, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['bug', 'enhancement', 'breaking-change', 'ignore-for-release']

@aomegax aomegax marked this pull request as ready for review March 22, 2023 09:06
@aomegax aomegax requested a review from a team March 22, 2023 09:06
pasqualespica
pasqualespica approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pasqualespica pasqualespica changed the title remove apim sub-key from header fix: PAGOPA-1300 remove apim sub-key from header Oct 27, 2023
@pasqualespica pasqualespica merged commit 886ed28 into main Oct 27, 2023
2 of 4 checks passed
@pasqualespica pasqualespica deleted the removed-apim-sub-key branch October 27, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

@jacopocarlini jacopocarlini jacopocarlini approved these changes

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@aomegax aomegax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aomegax @jacopocarlini @pasqualespica