Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add /report API and data-layer updates [PAGOPA-1446] #7

Merged
merged 15 commits into from
Jan 23, 2024

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Jan 22, 2024

List of Changes

  • Add the /report API to expose the overall status of a completed upload.
  • Update and create UploadStatus and UploadReport based on updates applied to the following function
  • Fix OpenAPI

Motivation and Context

How Has This Been Tested?

Manual test in following envs:

  • Local
  • DEV

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang added the enhancement New feature or request label Jan 22, 2024
@cap-ang cap-ang self-assigned this Jan 22, 2024
@cap-ang cap-ang requested a review from a team as a code owner January 22, 2024 14:22
Copy link

@alessio-acitelli alessio-acitelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add junit test for sonar coverage 👍

@cap-ang
Copy link
Contributor Author

cap-ang commented Jan 23, 2024

add junit test for sonar coverage 👍

I have added the tests, it seems that something is not working in the coverage calculation.

Warning: No coverage report can be found with sonar.coverage.jacoco.xmlReportPaths='./target/site/jacoco/jacoco.xml'.

Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@cap-ang cap-ang merged commit 25ec9a6 into main Jan 23, 2024
7 of 10 checks passed
@cap-ang cap-ang deleted the PAGOPA-1446-sviluppo-gpd-upload-improvement branch January 23, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants