Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAGOPA-1176] feat: Update and complete deploy Function Container App via GHA #13

Merged
merged 29 commits into from
Sep 14, 2023
Merged

[PAGOPA-1176] feat: Update and complete deploy Function Container App via GHA #13

merged 29 commits into from
Sep 14, 2023

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Sep 6, 2023 •
edited
Loading

List of Changes

  • fix role assignment issue;
  • add staging slot deploy logic.

Motivation and Context

With this PR, the migration to GHA of the deployment pipeline is completed.

How Has This Been Tested?

  • tested in DEV on production slot;
  • tested in UAT on temporary staging slot and production slot;

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

github-actions[bot]
github-actions bot requested changes Sep 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['bug', 'enhancement', 'breaking-change', 'ignore-for-release']

pagopa-github-bot and others added 12 commits September 6, 2023 12:46
@pagopa-github-bot
Bump to version 0.1.4-1-PAGOPA-1176-creare-un-gha-per-deploy-azure-fu…
1f4727a 
…nction [skip ci]
@cap-ang
[PAGOPA-1176] feat: Add github_runner
0d2f449
@pagopa-github-bot
Bump to version 0.1.4-2-PAGOPA-1176-creare-un-gha-per-deploy-azure-fu…
72c56e9 
…nction [skip ci]
@cap-ang
[PAGOPA-1176] fix
1fb5a1d
@pagopa-github-bot
Bump to version 0.1.4-3-PAGOPA-1176-creare-un-gha-per-deploy-azure-fu…
fadf6b6 
…nction [skip ci]
@cap-ang
[PAGOPA-1176] fix: Update azure login
a70dd09
@pagopa-github-bot
Bump to version 0.1.4-4-PAGOPA-1176-creare-un-gha-per-deploy-azure-fu…
90f46f2 
…nction [skip ci]
@cap-ang
[PAGOPA-1176] fix: Add environment
0e280b1
@pagopa-github-bot
Bump to version 0.1.4-5-PAGOPA-1176-creare-un-gha-per-deploy-azure-fu…
d89192e 
…nction [skip ci]
@pagopa-github-bot
Bump to version 0.1.4-6-PAGOPA-1176-creare-un-gha-per-deploy-azure-fu…
40feaec 
…nction [skip ci]
@cap-ang
[PAGOPA-1176] fix
272a866
@pagopa-github-bot
Bump to version 0.1.4-7-PAGOPA-1176-creare-un-gha-per-deploy-azure-fu…
08a66f0 
…nction [skip ci]
@andrea-deri andrea-deri temporarily deployed to dev September 8, 2023 15:57 — with GitHub Actions Inactive
@andrea-deri andrea-deri temporarily deployed to dev September 8, 2023 16:01 — with GitHub Actions Inactive
@cap-ang cap-ang temporarily deployed to dev September 11, 2023 12:31 — with GitHub Actions Inactive
@cap-ang cap-ang temporarily deployed to dev September 11, 2023 12:55 — with GitHub Actions Inactive
@cap-ang cap-ang temporarily deployed to dev September 11, 2023 13:05 — with GitHub Actions Inactive
@cap-ang cap-ang temporarily deployed to dev September 13, 2023 10:17 — with GitHub Actions Inactive
@cap-ang cap-ang temporarily deployed to dev September 13, 2023 10:18 — with GitHub Actions Inactive
@cap-ang cap-ang temporarily deployed to dev September 13, 2023 15:56 — with GitHub Actions Inactive
@cap-ang cap-ang changed the title [PAGOPA-1176] fix: Add runs-on [PAGOPA-1176] feat: Update and complete deploy Function Container App via GHA Sep 13, 2023
@cap-ang cap-ang added the ignore-for-release Ignore pull request from the release label Sep 13, 2023
@cap-ang cap-ang marked this pull request as ready for review September 13, 2023 16:14
@cap-ang cap-ang requested a review from a team as a code owner September 13, 2023 16:14
pasqualespica
pasqualespica approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kudos @AngeloCaporaso

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@cap-ang cap-ang merged commit cb311d9 into main Sep 14, 2023
9 of 10 checks passed
@cap-ang cap-ang deleted the PAGOPA-1176-creare-un-gha-per-deploy-azure-function branch September 14, 2023 08:55
This was referenced Sep 14, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@cap-ang cap-ang

Labels
ignore-for-release Ignore pull request from the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cap-ang @pasqualespica @andrea-deri @pagopa-github-bot @jacopocarlini