chore: [IOAPPX-396] remove NativeView part
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOAPPX-396 |
shadowsheep1
changed the title
NativeView part
ChrisMattew
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR removes the
NativeViewcomponent of the library, which is no longer in use. We have transitioned from utilizing theNativeViewto exclusively relying on theNativeModulefor native integration. This change simplifies the codebase by eliminating unused components and focuses solely on the module responsible for native functionality.Key Changes:
NativeViewand related dependencies.NativeModuleexclusively.Why this change?
The
NativeViewwas no longer being utilized, making it redundant. By removing it, we reduce complexity, improve maintainability, and ensure the library is streamlined around the core functionality provided byNativeModule.How to test
Run the example app on both Android and iOS physical devices and test a CieID login with IO-BE.