Enhancement: Update User Activity Query #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1909,7 +1909,7 @@ | |||
| "offset": 0, | |||
| "params": "{\"remote_id\": 49, \"database_name\": \"admin\"}", | |||
| "schema": "openedx", | |||
| "sql": "SELECT user_id,\n course_id,\n time,\n arrayJoin(range(floor(toUInt64(toUnixTimestamp(time) - 5)), ceil(toUInt64(toUnixTimestamp(time) + 5)))) AS timestamp\nFROM events\nWHERE event_source = 'browser'", | |||
| "sql": "SELECT user_id,\n course_id,\n time,\n arrayJoin(range(floor(toUInt64(toUnixTimestamp(time))), ceil(toUInt64(toUnixTimestamp(time) + 120)))) AS timestamp\nFROM events\nWHERE course_id <> '' and user_id > 0", | |||
There was a problem hiding this comment.
So we are ignoring browser entirely in this new query? Why is that? The timestamp change is understandable.
Also, if we can add some visualizations (before/after), it would make it easier to understand the impact.
There was a problem hiding this comment.
We are now picking both events(browser and server) where we have course_id and user_id because some events have source "server"(e.g edx.grades.problem.submitted) which we missed previously.
| @@ -0,0 +1 @@ | |||
| - [Improvement] Update User Activity dataset query to improve average time spent in course. (by @Fahadkhalid210) | |||
There was a problem hiding this comment.
nit: we can add context here on why this change provides a better data then before.
DawoudSheraz
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update user activity query to improve average time spent in course
Description:
In our ongoing analysis of PT data, we've identified discrepancies in the time spent by users in courses. Additionally, relying solely on "browser" events for these calculations has proven insufficient. After thorough investigation, we've determined that extending the time span from 10 seconds to 120 seconds and selecting all events where the course ID is not null provides a more accurate representation of the time users spend in courses.
Therefore, this pull request updates the query to enhance the accuracy of the average time spent in courses.
Before:
After:
