Skip to content

Commit

Permalink
improved code
Browse files Browse the repository at this point in the history
  • Loading branch information
FahadKhalid210 committed May 6, 2024
1 parent f8645c9 commit 1bca9ad
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 8 deletions.
8 changes: 8 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,15 @@ Add/Update Superset Configurations
----------------------------------

Use ``cairn-superset-settings`` patch to add or update `Superset configurations <https://github.com/apache/superset/blob/master/superset/config.py>`__.

e.g, to customize visualizations, add following configurations in ``cairn-superset-settings`` patch::

APP_NAME = "<APP_NAME>"
APP_ICON = "<APP_ICON>"
APP_ICON_WIDTH = <APP_ICON_WIDTH>

Then apply changes with::
tutor local launch

Troubleshooting
Expand Down
15 changes: 7 additions & 8 deletions tutorcairn/templates/cairn/apps/superset/superset_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,17 +84,22 @@
db=REDIS_CACHE_DB,
key_prefix="superset_results",
)
OPENEDX_LMS_ROOT_URL = "{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ LMS_HOST }}"
OPENEDX_CMS_ROOT_URL = "{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ CMS_HOST }}"

if os.environ.get("FLASK_ENV") == "development":
OPENEDX_LMS_ROOT_URL = "http://{{ LMS_HOST }}:8000"
OPENEDX_CMS_ROOT_URL = "http://{{ CMS_HOST }}:8001"

{% if CAIRN_ENABLE_SSO %}
# Authentication
# https://superset.apache.org/docs/installation/configuring-superset/#custom-oauth2-configuration
# https://flask-appbuilder.readthedocs.io/en/latest/security.html#authentication-oauth
from flask_appbuilder.security.manager import AUTH_OAUTH
AUTH_TYPE = AUTH_OAUTH
OPENEDX_LMS_ROOT_URL = "{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ LMS_HOST }}"

OPENEDX_SSO_CLIENT_ID = "{{ CAIRN_SSO_CLIENT_ID }}"
if os.environ.get("FLASK_ENV") == "development":
OPENEDX_LMS_ROOT_URL = "http://{{ LMS_HOST }}:8000"
OPENEDX_SSO_CLIENT_ID = "{{ CAIRN_SSO_CLIENT_ID }}-dev"
OAUTH_PROVIDERS = [
{
Expand Down Expand Up @@ -162,12 +167,6 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
"EMBEDDED_SUPERSET": True
}

# Embedded Dashboard CORS
OPENEDX_CMS_ROOT_URL = "{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ CMS_HOST }}"

if os.environ.get("FLASK_ENV") == "development":
OPENEDX_CMS_ROOT_URL = "http://{{ CMS_HOST }}:8001"

ENABLE_CORS=True
CORS_OPTIONS={
"origins": [
Expand Down

0 comments on commit 1bca9ad

Please sign in to comment.