Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Argo Events in Azure, setting version numbers in variables.tf #33

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

bbrandt
Copy link
Contributor

@bbrandt bbrandt commented Feb 28, 2023

Update of #19 with latest master merged and conflicts resolved. Moved version numbers for Argo and Argo events to variables.tf.

Draft PR #34 can be reviewed to verify the merge and conflict resolution was correct.

@bbrandt bbrandt changed the title Install Argo Events, setting version numbers in variables.tf Install Argo Events in Azure, setting version numbers in variables.tf Mar 3, 2023
@jackie-ob
Copy link
Contributor

@bbrandt Overall looks quite reasonable to me. Did you get a chance to use this PR in practice?

To set some expectations: Events triggering support is very close to merge. Once that is merged (perhaps by next week), I plan to also try out this PR as a kind of UAT (inclusive of exercising the said Metaflow eventing code). Then we would be in a good position to merge this PR.

@bbrandt
Copy link
Contributor Author

bbrandt commented Mar 14, 2023

@jackie-ob

This is the testing I've done:

  • Create, delete, and create a cluster using this script about 3-4 times.
    • Passed testing
  • Change variables for argo and metaflow versions and rerun script to perform upgrades of argo and metaflow.
    • This worked the first 1 or 2 times, but I am currently hitting an issue with upgrading that I will need to look into before I'd feel comfortable merging this.
    • My hypothesis is that this issue may track back to what was stated in Adding Argo Events - Azure #19 (comment) about "standard TF resource state management"
  • Created flows in Argo from the Metaflow console app and triggered them to run
    • Passed testing
  • Tested with Romain's new @conda decorator from https://github.com/Netflix/metaflow-nflx-extensions
    • Passed testing

Not tested:

  • Sending events through Argo events and having it trigger a metaflow flow
    • This was on my to do list, but other work got in the way. Unfortunately, I may not get back to this for a bit, so I will mark this PR as draft and trust you to take it from here.

@bbrandt bbrandt marked this pull request as draft March 14, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants