Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gazebo11.rb to build against ffmpeg@6 instead of ffmpeg (v. 7) #2637

Closed
wants to merge 1 commit into from

Conversation

gmerlino
Copy link

Fixes build failure.

@gmerlino gmerlino requested a review from scpeters as a code owner April 12, 2024 05:07
@osrf-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@osrf-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@scpeters
Copy link
Member

Thanks for the suggestion; I think this would work, but we'd have to set some environment variables in order to compile gazebo from source (see gazebo-tooling/release-tools#636). Since we've already merged support for ffmpeg 7 in gazebosim/gz-common#329, I'm inclined to port that patch to gazebo11

@scpeters
Copy link
Member

Thanks for the suggestion; I think this would work, but we'd have to set some environment variables in order to compile gazebo from source (see gazebo-tooling/release-tools#636). Since we've already merged support for ffmpeg 7 in gazebosim/gz-common#329, I'm inclined to port that patch to gazebo11

I've attempted a patch in gazebosim/gazebo-classic#3380

@gmerlino
Copy link
Author

Thanks for the suggestion; I think this would work, but we'd have to set some environment variables in order to compile gazebo from source (see gazebo-tooling/release-tools#636). Since we've already merged support for ffmpeg 7 in gazebosim/gz-common#329, I'm inclined to port that patch to gazebo11

I see your point about the envs (PKG_CONFIG_PATH I reckon). Building upon install works without any additional changes to the formula, though.

@scpeters
Copy link
Member

Thanks for your suggestion; this is a valid approach, but I've chosen to rebuild with the patch from gazebosim/gazebo-classic#3380 in #2636, so I'm going to close this now

@scpeters scpeters closed this Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants