fix(scripts/repin.sh): deactivate and delete env before recreating it

scripts/prune-environment.py

@@ -32,27 +32,21 @@ def iterate_deps(
                     break  # break out of the sep loop to avoid duplicate entries
 
 
+def split_off_pip_if_exists(env: dict[str, list[str]], has_pip: bool) -> list[str]:
+    return env["dependencies"][:-1] if has_pip else env["dependencies"]
+
+
 deps_not_pip: List[str] = []
 deps_pip: List[str] = []
 
 env_unpinned_contains_pip = "pip" in env_unpinned["dependencies"][-1]
 env_unpinned_dev_contains_pip = "pip" in env_unpinned_dev["dependencies"][-1]
 iterate_deps(
-    (
-        env_pinned["dependencies"][:-1]
-        if env_unpinned_contains_pip or env_unpinned_dev_contains_pip
-        else env_pinned["dependencies"]
-    ),
-    (
-        env_unpinned["dependencies"][:-1]
-        if env_unpinned_contains_pip
-        else env_unpinned["dependencies"]
-    )
-    + (
-        env_unpinned_dev["dependencies"][:-1]
-        if env_unpinned_dev_contains_pip
-        else env_unpinned_dev["dependencies"]
+    split_off_pip_if_exists(
+        env_pinned, env_unpinned_contains_pip or env_unpinned_dev_contains_pip
     ),
+    split_off_pip_if_exists(env_unpinned, env_unpinned_contains_pip)
+    + split_off_pip_if_exists(env_unpinned_dev, env_unpinned_dev_contains_pip),
     deps_not_pip,
 )
 

scripts/repin.sh

@@ -9,6 +9,11 @@ set -e
 # Make mamba available to shell script
 eval "$(conda shell.bash hook)"
 
+
+echo "Deactivating and destroying the openwpm env so it can be recreated"
+conda deactivate
+conda env remove -q -y -n openwpm
+
 # Create openwpm env with unpinned yaml file
 # `PYTHONNOUSERSITE` set so python ignores local user site libraries when building the env
 # See: https://github.com/openwpm/OpenWPM/pull/682#issuecomment-645648939
@@ -36,7 +41,6 @@ Darwin)
   ;;
 esac
 
-
 # Export the environment including manually specify channels
 mamba env export --no-builds --override-channels -c conda-forge -c main -f ../environment.yaml