fix(policy): DSP-54 make MatchSubjectMappings operator agnostic #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchak1
changed the title
jakedoublev
reviewed
Oct 17, 2024
| where += "((" + hasField + " AND " + hasValue + " AND " + hasInOperator + ")" + | ||
| " OR " + | ||
| "(" + hasField + " AND NOT " + hasValue + " AND " + hasNotInOperator + "))" | ||
| // Parses the json and matches the row if the selector exists: |
There was a problem hiding this comment.
I didn't touch this RPC to avoid merge conflicts, but perhaps you could remove this check and move it to the proto validation as part of this effort? https://github.com/opentdf/platform/pull/1658/files#diff-79178ab55805aac9e744330a45936ecde9e39baef7e8838764209f44b6a3f862R535 Similar to the work just done in GetAttributesByValueFQNs: #1657
There was a problem hiding this comment.
I also think we can ignore a check for values now that this route only drives based off selectors (explicitly not values after your current work here): https://github.com/opentdf/platform/pull/1658/files#diff-79178ab55805aac9e744330a45936ecde9e39baef7e8838764209f44b6a3f862R542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #1499