Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close serial port when disconnected to ensure clean reconnection #1636

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

sammdot
Copy link
Member

@sammdot sammdot commented Sep 28, 2023

In addition to the changes from #1560, this PR closes a serial port on error to handle this issue from #1054:

Now an exception in the run method is reported as an error to the system
and additionally the SerialStenotypeBase class does close the com port on
error.

Otherwise the com port resource might still be taken by plover upon
reconnect of the writer, and a different com port might be taken by the OS
and plover might not be able to reconnect to that machine.

Closes #1054.

  • News fragment added in news.d

@sammdot sammdot merged commit f3556d0 into openstenoproject:main Sep 28, 2023
12 checks passed
@sammdot sammdot deleted the handle-serial-disconnect branch September 28, 2023 18:15
@pianohacker
Copy link

I've been running a fork to work around this issue for literal years. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants