Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-43572: fix: update baremetal lane #57992

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-43572: fix: update baremetal lane #57992

wants to merge 1 commit into from
+1 −23

Conversation

eggfoobar
Copy link
Contributor

removed skip for monitor test failures
added conf step to pre step instead of test

@eggfoobar
fix: update baremetal lane
68557ef 
removed skip for monitor test failures
added conf step to pre step instead of test

Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 18, 2024
@openshift-ci-robot
Copy link
Contributor

@eggfoobar: This pull request references Jira Issue OCPBUGS-43572, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (nhamza@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

removed skip for monitor test failures
added conf step to pre step instead of test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@eggfoobar
Copy link
Contributor Author

/hold

Until we verify monitor errors are resolved

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eggfoobar
Once this PR has been reviewed and has the lgtm label, please assign tsorya, xueqzhan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@eggfoobar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-bootstrap-master-e2e-metal-single-node-live-iso openshift/cluster-bootstrap presubmit Registry content changed
pull-ci-openshift-cluster-bootstrap-release-4.19-e2e-metal-single-node-live-iso openshift/cluster-bootstrap presubmit Registry content changed
pull-ci-openshift-cluster-bootstrap-release-4.18-e2e-metal-single-node-live-iso openshift/cluster-bootstrap presubmit Registry content changed
pull-ci-openshift-cluster-bootstrap-release-4.17-e2e-metal-single-node-live-iso openshift/cluster-bootstrap presubmit Registry content changed
pull-ci-openshift-cluster-bootstrap-release-4.16-e2e-metal-single-node-live-iso openshift/cluster-bootstrap presubmit Registry content changed
pull-ci-openshift-cluster-bootstrap-release-4.15-e2e-metal-single-node-live-iso openshift/cluster-bootstrap presubmit Registry content changed
pull-ci-openshift-cluster-bootstrap-release-4.14-e2e-metal-single-node-live-iso openshift/cluster-bootstrap presubmit Registry content changed
pull-ci-openshift-cluster-bootstrap-release-4.13-e2e-metal-single-node-live-iso openshift/cluster-bootstrap presubmit Registry content changed
pull-ci-openshift-cluster-bootstrap-release-4.12-e2e-metal-single-node-live-iso openshift/cluster-bootstrap presubmit Registry content changed
pull-ci-openshift-cluster-bootstrap-release-4.11-e2e-metal-single-node-live-iso openshift/cluster-bootstrap presubmit Registry content changed
pull-ci-openshift-cluster-bootstrap-release-4.10-e2e-metal-single-node-live-iso openshift/cluster-bootstrap presubmit Registry content changed
pull-ci-openshift-cluster-bootstrap-release-4.9-e2e-metal-single-node-live-iso openshift/cluster-bootstrap presubmit Registry content changed
pull-ci-openshift-cluster-bootstrap-release-4.8-e2e-metal-single-node-live-iso openshift/cluster-bootstrap presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-master-e2e-metal-single-node-live-iso openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.19-e2e-metal-single-node-live-iso openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.18-e2e-metal-single-node-live-iso openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.17-e2e-metal-single-node-live-iso openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-metal-single-node-live-iso openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.15-e2e-metal-single-node-live-iso openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.14-e2e-metal-single-node-live-iso openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.13-e2e-metal-single-node-live-iso openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.12-e2e-metal-single-node-live-iso openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.11-e2e-metal-single-node-live-iso openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.10-e2e-metal-single-node-live-iso openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.9-e2e-metal-single-node-live-iso openshift/cluster-etcd-operator presubmit Registry content changed

A total of 86 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

@eggfoobar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/rh-ecosystem-edge/recert/release-4.14/baremetalds-sno-recert-cluster-rename 68557ef link unknown /pj-rehearse pull-ci-rh-ecosystem-edge-recert-release-4.14-baremetalds-sno-recert-cluster-rename

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eggfoobar
Copy link
Contributor Author

/pj-rehearse more

@openshift-ci-robot
Copy link
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepsm007 deepsm007 Awaiting requested review from deepsm007

@stbenjam stbenjam Awaiting requested review from stbenjam

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eggfoobar @openshift-ci-robot