Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSD-20514] Retry send SL notification #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

a7vicky
Copy link
Member

@a7vicky a7vicky commented Sep 22, 2024

What type of PR is this?

(feature)

What this PR does / why we need it?

Retry if it fails to send SL.

Which Jira/Github issue(s) this PR fixes?

Fixes #OSD-20514

Special notes for your reviewer:

Pre-checks (if applicable):

  • Tested latest changes against a cluster
  • Ran make generate command locally to validate code changes
  • Included documentation changes with PR

Copy link
Contributor

openshift-ci bot commented Sep 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7vicky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2024
@a7vicky a7vicky mentioned this pull request Sep 22, 2024
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 48.46%. Comparing base (9c8017f) to head (ef43c6f).

Files with missing lines Patch % Lines
pkg/handlers/webhookreceiver.go 87.50% 2 Missing and 1 partial ⚠️
pkg/handlers/reattempt.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   47.94%   48.46%   +0.52%     
==========================================
  Files          20       21       +1     
  Lines        1508     1531      +23     
==========================================
+ Hits          723      742      +19     
- Misses        745      747       +2     
- Partials       40       42       +2     
Flag Coverage Δ
48.46% <86.48%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/handlers/reattempt.go 84.61% <84.61%> (ø)
pkg/handlers/webhookreceiver.go 79.35% <87.50%> (+0.04%) ⬆️

Copy link
Contributor

openshift-ci bot commented Sep 22, 2024

@a7vicky: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@a7vicky
Copy link
Member Author

a7vicky commented Sep 23, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants