-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSD-20514] Retry send SL notification #111
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7vicky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 47.94% 48.46% +0.52%
==========================================
Files 20 21 +1
Lines 1508 1531 +23
==========================================
+ Hits 723 742 +19
- Misses 745 747 +2
- Partials 40 42 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
27e901a
to
ef43c6f
Compare
@a7vicky: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold |
What type of PR is this?
(feature)
What this PR does / why we need it?
Retry if it fails to send SL.
Which Jira/Github issue(s) this PR fixes?
Fixes #OSD-20514
Special notes for your reviewer:
Pre-checks (if applicable):
make generate
command locally to validate code changes