Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent jobs with configmaps #87

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

skordas
Copy link

@skordas skordas commented Oct 21, 2019

Workload to run concurrent jobs with configmaps.
Inspired by issue: kubernetes/kubernetes#74412 (comment)

@skordas
Copy link
Author

skordas commented Oct 21, 2019

@chaitanyaenr PTAL

Adding enabling/disabling pbench during workload run.
@skordas
Copy link
Author

skordas commented Oct 24, 2019

adding @mffiedler

@chaitanyaenr
Copy link
Member

Thanks for the PR @skordas, will test it out today.

## Smoke test variables

```
CONCURRENT_JOBS_NODE_COUNT=4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CONCURRENT_JOBS_NODE_COUNT, CONCURRENT_JOBS_MAXPODS, CONCURRENT_JOBS_POD_IMAGE, CONCURRENT_JOBS_STEPSIZE and CONCURRENT_JOBS_PAUSE vars are not being used by the workload.

number_of_concurrent_jobs: "{{ lookup('env', 'NUMBER_OF_CONCURRENT_JOBS')|default(300, true)|int }}"
job_completion_poll_attempts: "{{ lookup('env', 'JOB_COMPLETION_POLL_ATTEMPTS')|default(360, true)|int }}"

# Concurrent jobs smoke test workload specific parameters:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CONCURRENT_JOBS_NODE_COUNT, CONCURRENT_JOBS_MAXPODS, CONCURRENT_JOBS_POD_IMAGE, CONCURRENT_JOBS_STEPSIZE and CONCURRENT_JOBS_PAUSE vars are not being used by the workload.

spec:
containers:
- name: busybox
image: busybox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we parameterize the image instead of hard coding it please?

@chaitanyaenr
Copy link
Member

@skordas Tested the workload and it works fine, think we need to add the code to delete the objects created by the workload at the end of the run.

@mffiedler
Copy link

Looks good to me so far. +1 to @chaitanyaenr comment - need to leave cluster in pre-test state.

@chaitanyaenr
Copy link
Member

@skordas any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants