Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in final comparison stats with 'zero' values #587

Conversation

nathan-weinberg
Copy link
Contributor

Part of NETOBSERV-1543

Now that cloud-bulldozer/benchmark-comparison#76 is in we can begin adding metrics where we typically see a value of '0' to our Touchstone Comparsion, which will allow us to track errored and dropped flows more explicitly

Tested locally with Touchstone below:

[nathan@nathan-redhat netobserv-qe-scripts (crd-dir)]$ ./touchstone_compare.sh 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff     c9a81e65-64e9-4cb1-84e9-8f0792913882
File ‘netobserv_touchstone_tolerancy_config.json’ already there; not retrieving.

File ‘netobserv_touchstone_tolerancy_rules.yaml’ already there; not retrieving.

egrep: warning: egrep is obsolescent; using grep -E
+-----------------------+-----------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|      metric_name      |      metric_name      |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+-----------------------+-----------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| nFlowsProcessedTotals | nFlowsProcessedTotals | max(value) |  Fail  |  -75.49%  |              27288832.0              |              6688675.0               |
+-----------------------+-----------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+--------------------------------+--------------------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|          metric_name           |          metric_name           |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+--------------------------------+--------------------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| nFlowsProcessedPerMinuteTotals | nFlowsProcessedPerMinuteTotals | avg(value) |  Pass  |   2.75%   |          404844.96458333335          |           415993.42578125            |
+--------------------------------+--------------------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+---------------------+---------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|     metric_name     |     metric_name     |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+---------------------+---------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| nFlowsErroredTotals | nFlowsErroredTotals | max(value) |  Pass  |   0.00%   |                 0.0                  |                 0.0                  |
+---------------------+---------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+------------------------------+------------------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|         metric_name          |         metric_name          |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+------------------------------+------------------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| nFlowsErroredPerMinuteTotals | nFlowsErroredPerMinuteTotals | avg(value) |  Pass  |   0.00%   |                 0.0                  |                 0.0                  |
+------------------------------+------------------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+--------------------+--------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|    metric_name     |    metric_name     |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+--------------------+--------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| lokiRecordsWritten | lokiRecordsWritten | max(value) |  Fail  |  -75.49%  |              27281852.0              |              6686261.0               |
+--------------------+--------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+-----------------------------+-----------------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|         metric_name         |         metric_name         |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+-----------------------------+-----------------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| lokiRecordsWrittenPerMinute | lokiRecordsWrittenPerMinute | avg(value) |  Pass  |   2.85%   |              404579.425              |           416129.458984375           |
+-----------------------------+-----------------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+--------------------+--------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|    metric_name     |    metric_name     |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+--------------------+--------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| lokiRecordsDropped | lokiRecordsDropped | max(value) |  Pass  |   0.00%   |                 0.0                  |                 0.0                  |
+--------------------+--------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+-----------------------------+-----------------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|         metric_name         |         metric_name         |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+-----------------------------+-----------------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| lokiRecordsDroppedPerMinute | lokiRecordsDroppedPerMinute | avg(value) |  Pass  |   0.00%   |                 0.0                  |                 0.0                  |
+-----------------------------+-----------------------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+--------------+--------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| metric_name  | metric_name  |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+--------------+--------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| cpuFLPTotals | cpuFLPTotals | avg(value) |  Pass  |   0.71%   |          1.6973307073116302          |          1.7093896083533764          |
+--------------+--------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+---------------+---------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|  metric_name  |  metric_name  |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+---------------+---------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| cpuEBPFTotals | cpuEBPFTotals | avg(value) |  Pass  |  -1.20%   |          1.9241856733957927          |          1.901170140132308           |
+---------------+---------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+---------------+---------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|  metric_name  |  metric_name  |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+---------------+---------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| cpuLokiTotals | cpuLokiTotals | avg(value) |  Pass  |  -13.34%  |          0.400474754969279           |         0.34703495912253857          |
+---------------+---------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+----------------+----------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|  metric_name   |  metric_name   |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+----------------+----------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| cpuKafkaTotals | cpuKafkaTotals | avg(value) |  Pass  |  50.36%   |         0.12678426404794058          |         0.19063538499176502          |
+----------------+----------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+--------------+--------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| metric_name  | metric_name  |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+--------------+--------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| rssFLPTotals | rssFLPTotals | avg(value) |  Pass  |  -19.46%  |             1345875968.0             |             1083939840.0             |
+--------------+--------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+---------------+---------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|  metric_name  |  metric_name  |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+---------------+---------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| rssEBPFTotals | rssEBPFTotals | avg(value) |  Pass  |  -21.83%  |          2234848324.266667           |             1746938368.0             |
+---------------+---------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+---------------+---------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|  metric_name  |  metric_name  |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+---------------+---------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| rssLokiTotals | rssLokiTotals | avg(value) |  Pass  |  -56.21%  |            16757993472.0             |             7338251776.0             |
+---------------+---------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
--
+----------------+----------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
|  metric_name   |  metric_name   |   metric   | result | deviation | 0c6cdb12-ad06-4b4a-8fa2-fb2b92fdf7ff | c9a81e65-64e9-4cb1-84e9-8f0792913882 |
+----------------+----------------+------------+--------+-----------+--------------------------------------+--------------------------------------+
| rssKafkaTotals | rssKafkaTotals | avg(value) |  Pass  |  -28.33%  |          5287129361.066667           |             3789225216.0             |
+----------------+----------------+------------+--------+-----------+--------------------------------------+--------------------------------------+

Copy link

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: memodi, nathan-weinberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [memodi,nathan-weinberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 737e05f into openshift-qe:netobserv-perf-tests Mar 20, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants