Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm build script: Respect ARGUMENTS #464

Merged
merged 1 commit into from
May 31, 2024

Conversation

florian-h05
Copy link
Contributor

#456 made the prepare-docs step configurable through arguments passed in with the ARGUMENTS env var. However did the npm build script not respect them, this fixes this.

openhab#456 made the prepare-docs step configurable through arguments passed in with the ARGUMENTS env var.
However did the npm build script not respect them, this fixes this.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Copy link
Contributor Author

@stefan-hoehn Can you please merge?

Copy link
Collaborator

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefan-hoehn stefan-hoehn merged commit 26eddbf into openhab:main May 31, 2024
5 checks passed
@florian-h05 florian-h05 deleted the build-script-eval-args branch May 31, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants