Infrastructure: Disable Webpack TerserPlugin for cached globals injection #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the TerserPlugin to minimize web-packed to globals injection heavily decreased performance. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
changed the title
florian-h05
added a commit
to florian-h05/openhab-js
that referenced
this pull request
Aug 12, 2023
Fixes an issue, where the webpacked, globals injected `time.toZDT(items.Item)` did not work, because openhab#283 did revert openhab#273 and therefore constructor names are not kept. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
that referenced
this pull request
Aug 12, 2023
Fixes an issue, where the webpacked, globals injected `time.toZDT(items.Item)` did not work, because #283 did revert #273 and therefore constructor names are not kept. This introduces a `_isItem` helper method, which checks both constructor name or unique properties (`rawItem`). Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #273.
Using the Webpack TerserPlugin to minimize web-packed, cached globals injection heavily decreased performance, therefore remove it.