Improve unit tests

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
openhab · Dec 2, 2023 · d90abe2 · d90abe2
1 parent c2972d2
commit d90abe2
Showing 1 changed file with 15 additions and 6 deletions.
diff --git a/test/time.spec.js b/test/time.spec.js
@@ -1,5 +1,5 @@
 const time = require('../time');
-const { ZonedDateTime } = require('@js-joda/core');
+const { ZonedDateTime, ZoneId } = require('@js-joda/core');
 
 jest.mock('../items', () => ({
   Item: new Object() // eslint-disable-line no-new-object
@@ -67,13 +67,9 @@ describe('time.js', () => {
       });
     });
 
-    describe('parses ISO DateTime with zone offset and/or time/zone', () => {
+    describe('parses ISO DateTime with zone offset and time zone', () => {
       it.each([
         ['YYYY-MM-DDThh:mm:ss.f+HH:mm[SYSTEM]', '2016-03-18T12:38:23.561+01:00[SYSTEM]'],
-        ['YYYY-MM-DDThh:mm:ss.f+HH:mm', '2016-03-18T12:38:23.561+01:00'],
-        ['YYYY-MM-DDThh:mm:ss.f-HH:mm', '2016-03-18T12:38:23.56-04:30'],
-        ['YYYY-MM-DDThh:mm:ss.f+HHmm', '2016-03-18T12:38:23.561+0100'],
-        ['YYYY-MM-DDThh:mm:ss.f-HHmm', '2016-03-18T12:38:23.561-0430'],
         ['YYYY-MM-DDThh:mm:ssZ', '2022-12-24T18:30:35Z'],
         ['YYYY-MM-DDThh:mm:ss+HH:mm[timezone]', '2017-02-04T17:01:15.846+01:00[Europe/Paris]'],
         ['YYYY-MM-DDThh:mm:ss+HH:mm[timezone]', '2016-03-18T06:38:23.561-05:00[UTC-05:00]']
@@ -82,6 +78,19 @@ describe('time.js', () => {
       });
     });
 
+    describe('parses ISO DateTime with zone offset and without time zone and defaults to SYSTEM time zone', () => {
+      it.each([
+        ['YYYY-MM-DDThh:mm:ss.f+HH:mm', '2016-03-18T12:38:23.561+01:00'],
+        ['YYYY-MM-DDThh:mm:ss.f-HH:mm', '2016-03-18T12:38:23.56-04:30'],
+        ['YYYY-MM-DDThh:mm:ss.f+HHmm', '2016-03-18T12:38:23.561+0100'],
+        ['YYYY-MM-DDThh:mm:ss.f-HHmm', '2016-03-18T12:38:23.561-0430']
+      ])('accepts correct pattern %s', (pattern, isoStr) => {
+        const zdt = parseISO8601(isoStr);
+        expect(zdt).toBeInstanceOf(ZonedDateTime);
+        expect(zdt.zone()).toBe(ZoneId.SYSTEM);
+      });
+    });
+
     describe('rejects wrong ISO pattern', () => {
       it.each([
         ['hh:mm:ss,f', '18:00:00,4654'],