Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in synology.md #2159

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Fix errors in synology.md #2159

merged 1 commit into from
Nov 19, 2023

Conversation

lolodomo
Copy link
Contributor

Signed-off-by: Laurent Garnier lg.hc@free.fr

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Copy link

netlify bot commented Nov 19, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 599f3a6
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/6559ef0dee9fe4000842b709
😎 Deploy Preview https://deploy-preview-2159--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lolodomo
Copy link
Contributor Author

lolodomo commented Nov 19, 2023

@stefan-hoehn : please merge this one to "unlock" all other PRs.

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very much appreciated. I was just about to do that myself. I will then run all dependant other PRs as well. LGTM.

@stefan-hoehn stefan-hoehn merged commit 1903f69 into openhab:main Nov 19, 2023
4 checks passed
@lolodomo
Copy link
Contributor Author

I am going to update all my other PRs now to get successful builds.

@lolodomo lolodomo deleted the fix_synology branch November 19, 2023 11:35
@stefan-hoehn
Copy link
Contributor

stefan-hoehn commented Nov 19, 2023

Why do you need to update your PR? I reran #2154 and it still failed.

@stefan-hoehn stefan-hoehn added this to the 4.1 milestone Nov 19, 2023
@lolodomo
Copy link
Contributor Author

Why do you need to update your PR? I

To have updated synology.md in my branch.

This is done.
You can now expect all my PRs building with success.

@lolodomo
Copy link
Contributor Author

Apparently, it remains a problem at line 90 in synology.md !!!

@stefan-hoehn
Copy link
Contributor

My bad: I just noticed that I didn't look closely enough on synology.md as we overlooked one part:

image

@lolodomo
Copy link
Contributor Author

Error: installation/synology.md:98:1 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 3]

Can you please fix it ?
I will take a break now.

@stefan-hoehn
Copy link
Contributor

Also having a break now but I will take care asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants