Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra fields for addon discovery in addon.xml #2150

Merged
merged 7 commits into from
Dec 8, 2023

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Nov 10, 2023

Documentation of new fields in addon.xml

In OpenHAB core there is a PR #3865 which adds extra fields to the addon.xml file so that addons may be discovered during the initial setup of OH and thus be suggested to be installed during setup. This PR is the documentation for the additional fields.

Publish updated XML schema with new fields on OpenHAB Web Server

The extra fields introduced in PR #3865 are self documented in the XML schema file addon-1.0.0.xsd in 'org.openhab.core.addon', so the new version of this file needs to be manually copied to the OH web server as well.

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Copy link

netlify bot commented Nov 10, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit c4d4851
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/655ca0259a7cbc0008f660b5
😎 Deploy Preview https://deploy-preview-2150--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefan-hoehn
Copy link
Contributor

@andrewfg Did you see the failing markdown errors?

@andrewfg
Copy link
Contributor Author

Did you see the failing markdown errors?

I did now. There seems to be also some errors not related to this PR..

@stefan-hoehn
Copy link
Contributor

stefan-hoehn commented Nov 19, 2023

Did you see the failing markdown errors?

I did now. There seems to be also some errors not related to this PR..

Yep, I fixed the others but it seems unfortunately you need to rebase before it would work.
And can you please ping me when the related PR #3865 is merged?

@stefan-hoehn stefan-hoehn added this to the 4.1 milestone Nov 19, 2023
@andrewfg
Copy link
Contributor Author

ping me when the related PR #3865 is merged

I will do that.

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@stefan-hoehn
Copy link
Contributor

@andrewfg I was able to rebase the branch, so it based on the latest version of the files that prevented you to build. Please pull your repo accordingly before you continue.

@andrewfg
Copy link
Contributor Author

andrewfg commented Dec 5, 2023

@stefan-hoehn this PR is now ready to go.

@stefan-hoehn or @kaikreuzer can you kindly also update the xsd schemas on the web site?

@kaikreuzer
Copy link
Member

@andrewfg Already done, see openhab/openhab-core#3865 (comment).

@andrewfg
Copy link
Contributor Author

andrewfg commented Dec 7, 2023

@stefan-hoehn do I need to do anything more on this PR to ensure it gets merged?

openhab/openhab-core#3806 (comment)

@stefan-hoehn
Copy link
Contributor

LGTM, merging

@stefan-hoehn stefan-hoehn merged commit ae491a7 into openhab:main Dec 8, 2023
5 checks passed
@andrewfg andrewfg deleted the addon-suggestion-finder branch August 25, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants