Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable external fga server #11

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

le-yams
Copy link
Contributor

@le-yams le-yams commented May 15, 2024

Add inputs so an external server can be used to perform the tests

Description

To be able to run the tests against a specific OpenFGA version, we have to use an external server instead of the cli built-in one.
The PR adds two optional inputs so the user can specify a server url and its token.
If the server url is not specified, the cli built-in server is used (current behavior)

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@le-yams
Copy link
Contributor Author

le-yams commented May 15, 2024

To be done: adding an example and a test in the workflow [edit] done [/edit]

@le-yams le-yams force-pushed the feat/configurable_external_fga_server branch from 6081099 to d56a4f7 Compare May 16, 2024 08:09
@le-yams le-yams force-pushed the feat/configurable_external_fga_server branch 4 times, most recently from 3bc8a67 to f15b24d Compare May 16, 2024 13:02
@le-yams le-yams force-pushed the feat/configurable_external_fga_server branch from f15b24d to 74cb4ae Compare May 16, 2024 13:04
@le-yams le-yams marked this pull request as ready for review May 16, 2024 13:06
@le-yams le-yams requested a review from a team as a code owner May 16, 2024 13:06
@le-yams
Copy link
Contributor Author

le-yams commented May 16, 2024

I added the job test_conditions_support in the test workflow which verifies that the action actually runs the tests against the specified server

@rhamzeh
Copy link
Member

rhamzeh commented Jun 3, 2024

Thanks @le-yams! This is useful! Merging it. Hopefully some of the logic here can be dropped in a future iteration once we add the relevant flag in the CLI

Relevant conversation: openfga/cli#335

@rhamzeh rhamzeh merged commit 21b4215 into openfga:main Jun 3, 2024
9 checks passed
@yann-disanto
Copy link

Thanks @le-yams! This is useful! Merging it.

Thank you 😃

Hopefully some of the logic here can be dropped in a future iteration once we add the relevant flag in the CLI

Relevant conversation: openfga/cli#335

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants