Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the display of username suggestions #1270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

khudym
Copy link

@khudym khudym commented Jun 22, 2024

Description

Username suggestions functionality has been corrected to ensure proper behaviour.

  • fixed issue with suggestions being displayed in the wrong place;
  • added the ability to navigate through suggestions using the keyboard.

Related Pull Requests
PR to the open-release/redwood.master branch: #1279
PR to the open-release/quince.master branch: #1278

Steps to Reproduce:

1. suggestions being displayed in the wrong place

Open register page -> Enter some string into field "Full name" (e.g. Jack Smith) -> Click on field "Public username"

suggestions_rendering_bug.mov

2. impossible to enter suggestions field using the keyboard

Open register page -> Enter some string into field "Full name" (e.g. Jack Smith) -> press Tab button until you get to the "Public username" field

suggestions_keyboard.mov

After changes:

1. suggestions being displayed in the wrong place

fixed_suggestions_rendering_bug.mov

2. impossible to enter suggestions field using the keyboard

fixed_suggestions_keyboard.mov

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

openedx-webhooks commented Jun 22, 2024

Thanks for the pull request, @khudym!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-vanguards. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (e2a206c) to head (e39d41f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1270   +/-   ##
=======================================
  Coverage   87.69%   87.69%           
=======================================
  Files         124      124           
  Lines        2299     2300    +1     
  Branches      642      643    +1     
=======================================
+ Hits         2016     2017    +1     
  Misses        274      274           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khudym khudym marked this pull request as ready for review June 24, 2024 17:24
@khudym khudym requested a review from a team as a code owner June 24, 2024 17:24
@mphilbrick211
Copy link

Friendly follow-up on this, @openedx/2u-vanguards. Thanks!

@khudym khudym force-pushed the hudym/username-suggestions-fix branch from 092e1e7 to 30e0262 Compare July 22, 2024 20:42
@mphilbrick211
Copy link

Hi @openedx/vanguards @openedx/2u-vanguards! I think you are still maintainers of this repo. Just checking in to see if someone could please take a look here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants