feat: Add embeddable registration form #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## embeddable-registration-form #1026 +/- ##
================================================================
+ Coverage 84.51% 85.21% +0.70%
================================================================
Files 113 114 +1
Lines 2195 2326 +131
Branches 631 664 +33
================================================================
+ Hits 1855 1982 +127
- Misses 324 328 +4
Partials 16 16
☔ View full report in Codecov by Sentry. |
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1574/embedded-registration-form
branch
8 times, most recently
from
d5d3fcd
to
3dd17f9
Compare
zainab-amir
reviewed
Aug 14, 2023
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1574/embedded-registration-form
branch
from
3dd17f9
to
cac54f7
Compare
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1574/embedded-registration-form
branch
from
cac54f7
to
8897992
Compare
zainab-amir
changed the base branch from
master
to
embeddable-registration-form
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1574/embedded-registration-form
branch
5 times, most recently
from
68532fc
to
b02192e
Compare
zainab-amir
reviewed
Aug 21, 2023
src/register/RegistrationPage.jsx
Outdated
Comment on lines
419
to
427
|
|
||
| if (name === 'name') { | ||
| validateInput( | ||
| name, | ||
| value, | ||
| { name: formFields.name, username: formFields.username, form_field_key: name }, | ||
| !validationApiRateLimited, | ||
| false, | ||
| ); |
There was a problem hiding this comment.
This complete functionality was added for embedded registration. We don't need it for registration page: https://github.com/openedx/frontend-app-authn/pull/950/files
Description: Adding embedded registration form VAN-1574
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1574/embedded-registration-form
branch
from
b02192e
to
247e6ab
Compare
zainab-amir
approved these changes
Aug 21, 2023
ahtesham-quraish
merged commit 90db7ba
into
embeddable-registration-form
5 checks passed
ahtesham-quraish
deleted the
ahtesham/VAN-1574/embedded-registration-form
branch
syedsajjadkazmii
pushed a commit
that referenced
this pull request
Sep 7, 2023
Description: Adding embedded registration form VAN-1574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding embedded registration form
VAN-1574
How Has This Been Tested?
It has been tested locally.