-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix order numbers of steps in README #1005
Conversation
Thanks for the pull request, @serhatgktp! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the |
Hi @serhatgktp! Please let me know if you have any questions regarding submitting the CLA form. Thank you! |
Hi Michelle,
I’ve already filled out the form twice. I’m not sure I’ll fill it out again.
It’s just a typo fix in the README anyways. I’m sure the core contributors can just change it themselves if they truly care for it.
Best,
Efkan
…________________________________
From: Michelle Philbrick ***@***.***>
Sent: Monday, August 7, 2023 10:40 AM
To: openedx/frontend-app-authn ***@***.***>
Cc: Efkan S. Goktepe ***@***.***>; Mention ***@***.***>
Subject: Re: [openedx/frontend-app-authn] Fix order numbers of steps in README (PR #1005)
Hi @serhatgktp<https://github.com/serhatgktp>! Please let me know if you have any questions regarding submitting the CLA form<https://openedx.atlassian.net/wiki/spaces/COMM/pages/941457737/How+to+start+contributing+to+the+Open+edX+code+base>. Thank you!
—
Reply to this email directly, view it on GitHub<#1005 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASE2VDQCB5SFMS5I2OPJC2LXUD46VANCNFSM6AAAAAA22STIAI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi @serhatgktp! I checked on this for you, and we've received your corrected form (with the updated email address). It's awaiting review, and should be good-to-go in the next day or so. I will keep you posted if anything changes, but it's with our legal counsel at the moment for approval. |
Hi @serhatgktp , we need to have a valid Contributor License Agreement (CLA) in place for all contributions. See the welcome message above for the details about how to enroll. The process is different depending upon whether you are making this contribution as an individual or on behalf of your employer. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1005 +/- ##
=======================================
Coverage 84.38% 84.38%
=======================================
Files 112 112
Lines 2177 2177
Branches 633 633
=======================================
Hits 1837 1837
Misses 324 324
Partials 16 16 ☔ View full report in Codecov by Sentry. |
@serhatgktp |
@serhatgktp Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Fixes numbers of steps in the README.
JIRA
N/A
How Has This Been Tested?
N/A
Merge Checklist
Post-merge Checklist