Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order numbers of steps in README #1005

Closed
wants to merge 2 commits into from

Conversation

serhatgktp
Copy link

Description

Fixes numbers of steps in the README.

JIRA

N/A

How Has This Been Tested?

N/A

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@serhatgktp serhatgktp requested a review from a team as a code owner July 27, 2023 20:15
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 3, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @serhatgktp! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 7, 2023
@mphilbrick211
Copy link

Hi @serhatgktp! Please let me know if you have any questions regarding submitting the CLA form. Thank you!

@serhatgktp
Copy link
Author

serhatgktp commented Aug 7, 2023 via email

@mphilbrick211
Copy link

Hi @serhatgktp! I checked on this for you, and we've received your corrected form (with the updated email address). It's awaiting review, and should be good-to-go in the next day or so. I will keep you posted if anything changes, but it's with our legal counsel at the moment for approval.

@e0d
Copy link
Contributor

e0d commented Aug 16, 2023

Hi @serhatgktp , we need to have a valid Contributor License Agreement (CLA) in place for all contributions. See the welcome message above for the details about how to enroll. The process is different depending upon whether you are making this contribution as an individual or on behalf of your employer.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1399caf) 84.38% compared to head (74097e0) 84.38%.
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1005   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files         112      112           
  Lines        2177     2177           
  Branches      633      633           
=======================================
  Hits         1837     1837           
  Misses        324      324           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d
Copy link
Contributor

e0d commented Aug 16, 2023

@serhatgktp
I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

@e0d e0d added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Aug 16, 2023
@serhatgktp serhatgktp closed this Aug 16, 2023
@openedx-webhooks
Copy link

@serhatgktp Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants