feat: Update populate_exec command to cater to upcoming variant changes #4469
+76
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfaqShuaib09
force-pushed
the
afaq/prod-4206
branch
from
fcec2e6
to
2a38d86
Compare
| for variant in variants: | ||
| product.update({'variant': variant}) | ||
| output_dict = self.get_transformed_data(row, product) | ||
| output_writer = self.write_csv_row(output_writer, output_dict) |
There was a problem hiding this comment.
I would suggest creating a new function, let's say get_variants. In there, instead of if-else, have a variant list that gets values extended or appended based on the key. The code will be readable and easy to understand.
...apps/course_metadata/management/commands/tests/test_populate_executive_education_data_csv.py
Outdated
Show resolved
Hide resolved
AfaqShuaib09
force-pushed
the
afaq/prod-4206
branch
from
03031eb
to
023bb42
Compare
AfaqShuaib09
force-pushed
the
afaq/prod-4206
branch
from
023bb42
to
0b6c76d
Compare
| variants = [] | ||
|
|
||
| for key in variant_keys: | ||
| if key in product: |
There was a problem hiding this comment.
if key in product only checks the presence of key. An additional check for truthy value is needed here.
AfaqShuaib09
force-pushed
the
afaq/prod-4206
branch
from
0b6c76d
to
9490bef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-4206
This PR updates populate_exec command to cater to upcoming variant changes.
Variants data will be split up into multiple keys. The new format is as follows:
{ product: { ... variant: { ... }, custom_persentations: [ { variant }, { variant } ], future_variants: [ { variant }, { variant } ] } }