Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy of - fix: use "price" in ecommerce data loader (#4450) #4459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Copy of - fix: use "price" in ecommerce data loader (#4450) #4459

wants to merge 1 commit into from

Commits on Oct 4, 2024

  1. fix: use "price" in ecommerce data loader (openedx#4450) 

    * chore: bump upload-artifact GH task to v4

* fix: fallback to 'price' in ecommerce api loader

The Django Oscar upgrade of ecommerce changed the
item's price field from `price_excl_tax` to just `price`
causing the EcommerceApi data loader to fail.

This commit checks for the `price_excl_tax` key and
falls back to the 'price' value.

Ref: openedx/ecommerce#4050

* refactor: apply review suggestion on fix

* fix: update all references of `price_excl_tax` to price

* fix: remove extra item added accidentally
    @tecoholic
    tecoholic committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f6d429f View commit details
    Browse the repository at this point in the history