Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve(cluster add): add deploy type and fix a typo #367

Merged
merged 2 commits into from
Dec 7, 2023
Merged

improve(cluster add): add deploy type and fix a typo #367

merged 2 commits into from
Dec 7, 2023

Conversation

WhereAreBugs
Copy link

montaguelhz
montaguelhz reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@montaguelhz montaguelhz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

cli/command/cluster/add.go Outdated Show resolved Hide resolved
internal/storage/storage.go Outdated Show resolved Hide resolved
@WhereAreBugs WhereAreBugs changed the title add deploy type [feat(cluster add)]add deploy type Nov 24, 2023
@WhereAreBugs WhereAreBugs changed the title [feat(cluster add)]add deploy type [feat(cluster add)]add deploy type and fix a typo Nov 24, 2023
@WhereAreBugs WhereAreBugs changed the title [feat(cluster add)]add deploy type and fix a typo [improve(cluster add)]add deploy type and fix a typo Nov 24, 2023
@WhereAreBugs WhereAreBugs changed the title [improve(cluster add)]add deploy type and fix a typo improve(cluster add): add deploy type and fix a typo Nov 24, 2023
montaguelhz
montaguelhz approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@montaguelhz montaguelhz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caoxianfei1
caoxianfei1 reviewed Dec 1, 2023
View reviewed changes
internal/storage/sql.go Outdated Show resolved Hide resolved
caoxianfei1
caoxianfei1 reviewed Dec 3, 2023
View reviewed changes
internal/storage/sql.go Outdated Show resolved Hide resolved
@caoxianfei1
Copy link
Contributor

caoxianfei1 commented Dec 3, 2023 •
edited
Loading

@WhereAreBugs One commit accomplishes only one thing is more standardized.

caoxianfei1
caoxianfei1 reviewed Dec 4, 2023
View reviewed changes
internal/storage/sql.go Outdated Show resolved Hide resolved
caoxianfei1
caoxianfei1 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@caoxianfei1 caoxianfei1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Wine93
Wine93 reviewed Dec 4, 2023
View reviewed changes
cli/command/cluster/add.go Outdated Show resolved Hide resolved
@WhereAreBugs
Feature(cluster add): add deploy type parameter
4d99c3d 
Signed-off-by: WhereAreBugs <2572414306@qq.com>
@WhereAreBugs
Fix(typo): fix an spelling mistake in code.
85b2808 
Signed-off-by: WhereAreBugs <2572414306@qq.com>
@caoxianfei1 caoxianfei1 merged commit e362387 into opencurve:develop Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wine93 Wine93 Wine93 left review comments

@montaguelhz montaguelhz montaguelhz approved these changes

@caoxianfei1 caoxianfei1 caoxianfei1 approved these changes

Assignees
No one assigned
Labels
developer activities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WhereAreBugs @caoxianfei1 @Wine93 @montaguelhz