Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back in pvnet ecmwf old model #141

Merged
merged 4 commits into from
Oct 15, 2024
Merged

add back in pvnet ecmwf old model #141

merged 4 commits into from
Oct 15, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Oct 15, 2024

Pull Request

Description

  • add back in old pvnet model
  • add back in old pvnet ecmwf model
  • add option to switch from models using ocf_data_sampler and ocf_datapipes
  • added new test in

As there are code changes since 2.3.30 the old version, it would be great to run the models with no ocf_data_sampler on dev for a bit, just to check they are working similar to production

Helps withs #123

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterdudfield peterdudfield merged commit fb3b6c4 into main Oct 15, 2024
2 checks passed
@peterdudfield peterdudfield deleted the issue/use-legacy branch October 15, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants