Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blend ecwmf only #37

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Blend ecwmf only #37

merged 7 commits into from
Oct 15, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Oct 14, 2024 •
edited
Loading

Pull Request

Description

If pvnet and pvnet day is not working, blend in pvnet_ecmwf only, instead of national_xg
If pvnet_ecmwf not there, use national_xg

  • add the pvnet_ecmwf model, which maent updating the tests
  • added pvnet_ecmwf to the weights,
  • added a test to check it works

Helps with openclimatefix/uk-pvnet-app#123

How Has This Been Tested?

CI tests + added extra

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Sukh-P
Sukh-P reviewed Oct 15, 2024
View reviewed changes
tests/test_app.py Outdated Show resolved Hide resolved
Sukh-P
Sukh-P reviewed Oct 15, 2024
View reviewed changes
readme.md Outdated Show resolved Hide resolved
Sukh-P
Sukh-P approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work adding this in here!

Sukh-P
Sukh-P reviewed Oct 15, 2024
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
peterdudfield and others added 3 commits October 15, 2024 09:42
@peterdudfield @Sukh-P
Update tests/conftest.py
0fbfd4e 
Co-authored-by: Sukhil Patel <42407101+Sukh-P@users.noreply.github.com>
@peterdudfield
pr comments
e93e75e
@peterdudfield
Merge commit '0fbfd4ec04e35c587843c10a4a719674378f329c' into blend-ec…
1b981b9 
…wmf-only
@peterdudfield peterdudfield merged commit 2458b07 into main Oct 15, 2024
3 checks passed
@peterdudfield peterdudfield deleted the blend-ecwmf-only branch October 15, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sukh-P Sukh-P Sukh-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @Sukh-P