Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add forecast ECMWF pvnet only #637

Merged
merged 7 commits into from
Oct 14, 2024
Merged

add forecast ECMWF pvnet only #637

merged 7 commits into from
Oct 14, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Oct 14, 2024 •
edited
Loading

Pull Request

Description

Get pvnet working with just ECMWF

  • ECS task for pvnet ecmwf
  • airflow dag, run ECMWF only if PVnet fails

Helps with openclimatefix/uk-pvnet-app#123

How Has This Been Tested?

  • CI tests

  • Uploaded to airflow manually, and check task is triggered

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review October 14, 2024 13:48
@peterdudfield peterdudfield merged commit c676a5d into main Oct 14, 2024
5 checks passed
@peterdudfield peterdudfield deleted the issue/pvnet-ecmwf branch October 14, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsjc devsjc devsjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @devsjc