Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Java auto-instrumentation image 1.33.5 #3176

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

pavolloffay
Copy link
Member

Description:

Link to tracking Issue(s):

  • Resolves: #issue-number

Testing:

Documentation:

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 29, 2024
@pavolloffay pavolloffay requested a review from a team July 29, 2024 13:31
Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavolloffay is the plan to continue publishing both images? i.e. swap this back to 2.6.0 later?

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaronoff97 this file only controls the image that gets released when this is merged to main. We should continue supporting 1.x as the default version in the root version.txt. The auto-update job will automatically swap this to 2.x on the next release.

@pavolloffay
Copy link
Member Author

I think we should keep publishing both version trains.

It's a low-effort, it would be just nice to update the GH action to submit PRs automatically for both.

@pavolloffay pavolloffay merged commit 5aa2bef into open-telemetry:main Jul 29, 2024
34 checks passed
@pavolloffay pavolloffay mentioned this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants